Add feature: dictionary settings #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Oct 11, 2023
curquiza
reviewed
Oct 11, 2023
curquiza
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Hello @hasan-raja
thanks a lot for your PR
looks the Ci rust-format is failing, otherwise the PR is good
can you fix it before I merge?
|
Hi @curquiza made an update based on rust format |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #527
What does this PR do?
dictionarysetting to theSettingsstruct, providing users with a flexible way to manage their search dictionary.dictionarysetting:get_dictionary: Retrieves the current dictionary configuration.set_dictionary: Updates the dictionary with a new configuration.reset_dictionary: Resets the dictionary configuration to default values.PR checklist
Please check if your PR fulfills the following requirements:
.code-samples.meilisearch.yamlfile to incorporate new examples for theget_dictionary,set_dictionary, andreset_dictionarymethods.Please review and provide feedback on the changes introduced in this pull request.